Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: 2 Major 2 Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.2.2
    • Component/s: Core
    • Labels:
      None
    • Terracotta Target:
      Unknown
    • Story Points:
      1
    • Bug Found In Detail:
      Quartz 2.2.1

      Description

      org.quartz.core.QuartzScheduler.shouldRunUpdateCheck() method checks property name instead of property value. Always it returns true.

      private boolean shouldRunUpdateCheck() {
          if(resources.isRunUpdateCheck() && !Boolean.getBoolean(StdSchedulerFactory.PROP_SCHED_SKIP_UPDATE_CHECK) &&
                      !Boolean.getBoolean("org.terracotta.quartz.skipUpdateCheck")) {
              return true;
          }
          return false;
      }
      

        Activity

        Hide
        Hung Huynh added a comment -

        I've tested these properties and they all checked out. I'm not sure what you meant by "shouldRunUpdateCheck() method checks property name instead of property value"? It's a proper call to check for value of those properties.

        Do you have a test case to demonstrate a failure? Update check is on by default unless you turn it off by one of these methods:

        1. add org.quartz.scheduler.skipUpdateCheck = true in quartz.properties

        2. add -Dorg.quartz.scheduler.skipUpdateCheck=true to system properties

        3. add -Dorg.terracotta.quartz.skipUpdateCheck=true to system properties

        Show
        Hung Huynh added a comment - I've tested these properties and they all checked out. I'm not sure what you meant by "shouldRunUpdateCheck() method checks property name instead of property value"? It's a proper call to check for value of those properties. Do you have a test case to demonstrate a failure? Update check is on by default unless you turn it off by one of these methods: 1. add org.quartz.scheduler.skipUpdateCheck = true in quartz.properties 2. add -Dorg.quartz.scheduler.skipUpdateCheck=true to system properties 3. add -Dorg.terracotta.quartz.skipUpdateCheck=true to system properties
        Hide
        Roberto Gonzalez Blazquez added a comment -

        Sorry, I mistook the "getBoolean" method with the "parseBoolean".

        Show
        Roberto Gonzalez Blazquez added a comment - Sorry, I mistook the "getBoolean" method with the "parseBoolean".

          People

          • Assignee:
            Hung Huynh
            Reporter:
            Roberto Gonzalez Blazquez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: