Details

    • Type: Task Task
    • Status: Closed
    • Priority: 2 Major 2 Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.2
    • Component/s: Core
    • Labels:
      None
    • Terracotta Target:
      Gladstone
    • Fixed In Revision:
      2015

      Description

      No classes implementing Semaphore require a Connection parameter as of now (it is never used).
      Also the isLockOwner(Connection conn, String lockName) method is never called outside a Semaphore, so it does not need to be exposed through the Semaphore interface.
      Semaphore is an interface specific to the JdbcJobStore, (internal implementation) it can be changed without warnings.

        Activity

        Hide
        Anthony Dahanne Dahanne added a comment -

        the title is almost true : DBSemaphore does need a connection for its obtainLock method; so the scope is rather now to clean the releaseLock, not to use a connection paramter, and also to remove isLockOwner from the interface

        Show
        Anthony Dahanne Dahanne added a comment - the title is almost true : DBSemaphore does need a connection for its obtainLock method; so the scope is rather now to clean the releaseLock, not to use a connection paramter, and also to remove isLockOwner from the interface
        Hide
        Anthony Dahanne Dahanne added a comment - - edited

        just removed the isLockOwner method, and removed the connection parameter from the releaseLock method in the Semaphore interface:

        -void releaseLock(Connection conn, String lockName) throws LockException;
        +void releaseLock(String lockName) throws LockException;

        -boolean isLockOwner(Connection conn, String lockName) throws LockException;

        http://svn.terracotta.org/fisheye/cru/CR-492

        Show
        Anthony Dahanne Dahanne added a comment - - edited just removed the isLockOwner method, and removed the connection parameter from the releaseLock method in the Semaphore interface: -void releaseLock(Connection conn, String lockName) throws LockException; +void releaseLock(String lockName) throws LockException; -boolean isLockOwner(Connection conn, String lockName) throws LockException; http://svn.terracotta.org/fisheye/cru/CR-492

          People

          • Assignee:
            Anthony Dahanne Dahanne
            Reporter:
            Anthony Dahanne Dahanne
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: