Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: 2 Major 2 Major
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 2.2
    • Component/s: Core
    • Labels:
      None
    • Terracotta Target:
      Vicente
    • Fixed In Revision:
      2002

      Description

      Current existing ConnectionProvider implementation would create and init a pool in its constructor. In cases where if we want to take advantage of their class with setters and getters, we can't initialize the pool in the constructor!

      For example, in here http://code.google.com/p/myschedule/source/browse/bonecp-quartz/src/main/java/deng/quartz/bonecp/BoneCpConnectionProvider.java?repo=experiment

      So the workaround is that I have to check pool instance every time in getConnection() instead.

      It would be nice to have a distinct initialise() in ConnectionProvider interface instead.

        Activity

        Hide
        James House added a comment -

        A fair suggestion!

        Show
        James House added a comment - A fair suggestion!
        Hide
        Anthony Dahanne Dahanne added a comment -

        the changes are :

        • adding an initialize() method to the interface ConnectionProvider;
        • adding an empty overriding initialize() method to the current ConnectionProvider implementers, except for weblogic;
        • adding in StdSchedulerFactory a call to initialize(), with a test to verify initialize() is called before getConnection() when dealing with a custom ConnectionProvider
        Show
        Anthony Dahanne Dahanne added a comment - the changes are : adding an initialize() method to the interface ConnectionProvider; adding an empty overriding initialize() method to the current ConnectionProvider implementers, except for weblogic; adding in StdSchedulerFactory a call to initialize(), with a test to verify initialize() is called before getConnection() when dealing with a custom ConnectionProvider

          People

          • Assignee:
            Anthony Dahanne Dahanne
            Reporter:
            Zemian Deng
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: