Details

    • Type: Task Task
    • Status: Closed
    • Priority: 2 Major 2 Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.8.6, 2.1.1, 2.2
    • Component/s: Build
    • Labels:
      None
    • Terracotta Target:
      Vicente
    • Fixed In Revision:
      1698

      Description

      This has been discussed in dev list:
      http://lists.terracotta.org/pipermail/quartz-dev/2011-July/000035.html

      So I will create a task to track it.

      1) Upgrade junit to version 4.8.2 in project pom.xml
      JUnit4 supports annotation and simplify unit testing.
      I think junit4 is backward compatible, so existing tests should still able to run without harm.

      2) Add hamcrest as test library to project pom.xml.
      This allow a simple and uniform "assertThat(expected, Matchers.xxx(actual))" through all unit tests.

      sample:
      <dependency>
      <groupId>org.hamcrest</groupId>
      <artifactId>hamcrest-library</artifactId>
      <version>1.2</version>
      <scope>test</scope>
      </dependency>
      <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>4.8.2</version>
      <scope>test</scope>
      </dependency>

        Activity

        Hide
        Zemian Deng added a comment -

        I have asked feedback here: http://lists.terracotta.org/pipermail/quartz-dev/2011-September/000123.html

        no reply yet.

        If no one objects, I can try to make the change.

        Show
        Zemian Deng added a comment - I have asked feedback here: http://lists.terracotta.org/pipermail/quartz-dev/2011-September/000123.html no reply yet. If no one objects, I can try to make the change.
        Hide
        Hung Huynh added a comment -

        Zemian, I've done this for trunk already. If you like to have these in other branches, feel free to add them there also.

        Show
        Hung Huynh added a comment - Zemian, I've done this for trunk already. If you like to have these in other branches, feel free to add them there also.
        Hide
        Hung Huynh added a comment -

        I've added these into quartz-2.1.x branch also

        Show
        Hung Huynh added a comment - I've added these into quartz-2.1.x branch also
        Hide
        Zemian Deng added a comment -

        That's great! Thank you updating the pom Hung.

        However, in the dev list email, I have mentioned that we don't really need these:
        <dependency>
        <groupId>javax.activation</groupId>
        <artifactId>activation</artifactId>
        <version>1.1</version>
        <scope>provided</scope>
        </dependency>
        <dependency>
        <groupId>javax.mail</groupId>
        <artifactId>mail</artifactId>
        <version>1.4.1</version>
        <scope>provided</scope>
        </dependency>
        <dependency>
        <groupId>javax.transaction</groupId>
        <artifactId>jta</artifactId>
        <version>1.1</version>
        </dependency>
        <dependency>
        <groupId>javax.jms</groupId>
        <artifactId>jms</artifactId>
        <version>1.1</version>
        <scope>provided</scope>
        </dependency>
        <dependency>
        <groupId>javax.servlet</groupId>
        <artifactId>servlet-api</artifactId>
        <version>2.5</version>
        <scope>provided</scope>
        </dependency>

        Because all above are already included by:
        <dependency>
        <groupId>org.apache.openejb</groupId>
        <artifactId>javaee-api</artifactId>
        <version>5.0-2</version>
        <scope>provided</scope>
        </dependency>

        Also, I suggest that you switch the order of the following to the order I stated above. I have come across where the overlapped classese comes with junit do give you trouble. The simple ordering fixed it though.
        <dependency>
        <groupId>junit</groupId>
        <artifactId>junit</artifactId>
        <version>4.8.2</version>
        <scope>test</scope>
        </dependency>
        <dependency>
        <groupId>org.hamcrest</groupId>
        <artifactId>hamcrest-library</artifactId>
        <version>1.2</version>
        <scope>test</scope>
        </dependency>

        Show
        Zemian Deng added a comment - That's great! Thank you updating the pom Hung. However, in the dev list email, I have mentioned that we don't really need these: <dependency> <groupId>javax.activation</groupId> <artifactId>activation</artifactId> <version>1.1</version> <scope>provided</scope> </dependency> <dependency> <groupId>javax.mail</groupId> <artifactId>mail</artifactId> <version>1.4.1</version> <scope>provided</scope> </dependency> <dependency> <groupId>javax.transaction</groupId> <artifactId>jta</artifactId> <version>1.1</version> </dependency> <dependency> <groupId>javax.jms</groupId> <artifactId>jms</artifactId> <version>1.1</version> <scope>provided</scope> </dependency> <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> <version>2.5</version> <scope>provided</scope> </dependency> Because all above are already included by: <dependency> <groupId>org.apache.openejb</groupId> <artifactId>javaee-api</artifactId> <version>5.0-2</version> <scope>provided</scope> </dependency> Also, I suggest that you switch the order of the following to the order I stated above. I have come across where the overlapped classese comes with junit do give you trouble. The simple ordering fixed it though. <dependency> <groupId>junit</groupId> <artifactId>junit</artifactId> <version>4.8.2</version> <scope>test</scope> </dependency> <dependency> <groupId>org.hamcrest</groupId> <artifactId>hamcrest-library</artifactId> <version>1.2</version> <scope>test</scope> </dependency>
        Hide
        Zemian Deng added a comment -

        I have updated the pom.xml according to my proposed changes to all three of these locations:
        trunk (r1698)
        quartz-2.1.x (r1699)
        quartz-1.8.x (r1700)

        Show
        Zemian Deng added a comment - I have updated the pom.xml according to my proposed changes to all three of these locations: trunk (r1698) quartz-2.1.x (r1699) quartz-1.8.x (r1700)
        Hide
        Zemian Deng added a comment -

        Hum... I seems to have missed to marked as fix per version label in this Jira issue. Perhaps someone who has access can update that.

        Show
        Zemian Deng added a comment - Hum... I seems to have missed to marked as fix per version label in this Jira issue. Perhaps someone who has access can update that.
        Hide
        Hung Huynh added a comment -

        I fixed the "Fix Versions" to include 1.8.6, 2.1.1 and 2.2

        Show
        Hung Huynh added a comment - I fixed the "Fix Versions" to include 1.8.6, 2.1.1 and 2.2

          People

          • Assignee:
            Zemian Deng
            Reporter:
            Zemian Deng
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: