EHC ❯ Enhance DefaultSizeOfEngine to be more easily overridable to allow for custom user filters and SizeOf implementations
-
Patch
-
Status: Resolved
-
2 Major
-
Resolution: Fixed
-
ehcache-core
-
-
alexsnaps
-
Reporter: ssievers
-
July 10, 2012
-
1
-
Watchers: 4
-
December 23, 2013
-
December 23, 2013
Attachments
Description
Currently DefaultSizeOfEngine cannot be easily extended in order to make simple changes, such as adding a custom user filter or a specific SizeOf implementation.
I have provided a patch that refactors this class to make it a bit easier to customize the SizeOfEngine behavior without having to write one from scratch.
Comments
Alexander Snaps 2012-07-10
Fiona OShea 2012-07-10
Thank you for your contribution, we will review the patch. Please fill out our Contributor Agreement http://www.terracotta.org/confluence/download/attachments/27918462/Individual+Contributor+Agreement.pdf?version=2 to allow us to apply the patch if it is accepted.
Fiona OShea 2012-07-16
Can you verify that this is even something we would want to do? He hasn’t sent in a contributor agreement yet, so no action on the patch is required at this point.
Fiona OShea 2012-07-24
Received contributor agreement from Stanton on 7/19/2012 - OK to review
Alexander Snaps 2013-12-23
Released as an additional module, available here : http://terracotta-oss.github.io/ehcache-sizeofengine/
Need to carefully review if his approach (protected method to override the default sizeOf) is suitable or not… Just quickly glanced at the patch