• Bug
  • Status: Closed
  • 2 Major
  • Resolution: Fixed
  • ehcache-web
  • hsingh
  • Reporter:
  • November 25, 2009
  • 0
  • Watchers: 0
  • January 17, 2013
  • December 14, 2009

Attachments

Description

I checked

http://svn.terracotta.org/svn/ehcache/trunk/web/src/main/java/net/sf/ehcache/constructs/web/GenericResponseWrapper.java

which still has the bug (ie, setHeader calling addHeader). Am I looking in the wrong place?

Thanks, Ben

On Tue, Nov 24, 2009 at 2:13 PM, Greg Luck [email protected] wrote: Benjamin Have you tested trunk of ehcache-web. We fixed a set headers issue. Should be released this week. It would be good if you can check that trunk fixes your issue. On 23/11/2009, at 12:00 PM, Benjamin Schmaus wrote:

Hi, Greg.

I came across a bug in ehcache-web the other day whereby the setHeader method of the GenericResponseWrapper class incorrectly calls addHeader instead of overwriting any existing value for the given HTTP header. I’ve written a patch along with a unit test that I believe fixes the problem.

I noticed the problem via the GzipFilter class, which uses the GenericResponseWrapper class internally.

Please let me know if this issue should be directed elsewhere or if you have any questions.

Thanks, Ben

Comments

gluck 2009-11-25

Ben

We can fix the bug. If you want us to use your patch and test you need to fill out a contributor agreement and sign then mail or scan and mail back to us. Download from http://www.terracotta.org/confluence/display/devdocs/How+To+Become+A+Contributor

Steve Harris 2009-11-25

Can someone make this happen? Sooner the better so we can get the webcache thing out

gluck 2009-12-14

Fixed in 2.0.0.