EHC ❯ Perform logging of MaxDepthExceededException in a protected method of DefaultSizeOfEngine

• Type: Patch
• Status: New
• Priority: 2 Major
• Resolution:
• Component/s: ehcache-core
• Labels:

• Assignee: ljacomet
• Reporter: kmacleod
• Created: October 16, 2013
• Votes: 0
• Watchers: 4
• Updated:

  November 04, 2013
• Resolved:

Attachments

• kmacleod (10.00 k) text/plain Perform_MaxDepthExceededException_logging_in_a_separate,_overrideable_method_.patch

Description

When {{DefaultSizeOfEngine #sizeOf}} catches a {{MaxDepthExceededException}}, it logs it in a complex multi-line logging expression. The information that is logged isn’t especially useful, though, and we find it often swamps the logs with unhelpful information.

Rather than try to come up with a generic, works-for-everyone log format, I thought the easiest first step is to perform the logging in a separate, protected method of {{DefaultSizeOfEngine}}, which allows custom {{SizeOfEngine}} implementations to override the logging to fit their own needs.

I’ve attached a patch that achieves this.

Comments

Louis Jacomet Jacomet 2013-10-16

What do you want to achieve here that would not be achieved by improving the logging as requested in EHC-1056 and relying on configuring your logger to silence or not the log statements?

Kenny MacLeod 2013-10-16

EHC-1056 would improve the general situation that would provide more useful logging in the majority of cases. However, we have use-cases here that would involve digging into specific types to provide extended diagnostic information on the cause of the depth-exceeded exception. This by necessity would be application-specific code, and would require a subclass or re-implementation of {{DefaultSizeOfEngine}}.