• Bug
  • Status: Closed
  • 0 Showstopper
  • Resolution: Fixed
  • Kit & Installation
  • kkannaiy
  • Reporter: gkeim
  • January 16, 2008
  • 0
  • Watchers: 0
  • February 12, 2013
  • March 28, 2008

Description

This issue came from http://forums.terracotta.org/forums/posts/list/731.page

The Windows scripts convert directory paths to 8.3 form to avoid trouble with spaces. The command that does the conversion doesn’t work with a path like C:\Program Files\Java\jdk1.6.0, but does with C:\Program Files\Java\jdk1.6.0_04.

I guess we have to go back to the old way of quoting the given paths, from 2.4.

Comments

Fiona OShea 2008-01-17

Were we fixing another issue when we changed it for 2.5? Will we lose the original fix if we go back to 2.4 style quoting of strings? thanks

Fiona OShea 2008-01-21

The workaround is to install (JDK) to a path without spaces. Fiona to add to known issues

Fiona OShea 2008-01-23

Added to Known issues in 2.5 release notes. This should be reviewed for Pacheco and a solution to the bug found

Gary Keim 2008-01-23

Going back to the 2.4 versions should be good.

Fiona OShea 2008-03-05

Figure out who owns packaging

Juris Galang 2008-03-17

r7575 Applied fix to WebSphere Applicaton Server scripts.

r7570: Applied broken path fixes for all other Windows scripts. It was also broken for other constructed paths besides, JAVA_HOME.

NOTES: The issue was that in Windows when JAVA_HOME is defined, and the path contains spaces, it will already have quotes around the path, this was screwing up our scripts when we put yet another set of quotes around it before shortening it into the 8.3 format.

We now remove the quotes from JAVA_HOME if it is defined, and re-add it, before shortening to 8.3 format.

See also: revs 7548, rev7553, 7555, 7557 (trunk)

Kalai Kannaiyan 2008-03-24

Tested with Terracotta trunk-nightly-rev7671, with JAVA_HOME=C:\Program Files\Java\jdk1.6.0 on windows

scripts are not working.

Steps:

  1. Install the kit
  2. set JAVA_HOME=”C:\Program Files\Java\jdk1.6.0”
  3. Navigate to C:\Program Files\Terracotta\terracotta-trunk-nightly-rev7671\bin and execute version.bat

Actual: The system cannot find the path specified.

Note: It is working fine when JAVA_HOME is set to “C:\Program Files\Java\jdk1.6.0_04”

Juris Galang 2008-03-28

Reverting back to not using or converting paths to 8dot3 format. Windows facility for effecting this isn’t very reliable - it may work on a certain machine, but wont on another with the same OS config.

I’ve added an extra line however to remove the quotes from the incoming paths, and re-add it ourselves, which seems to be causing the issue the prompted this changeset. The line was (and similar other lines):

set JAVA_HOME=”%JAVA_HOME:”=%”

Also, we now strip quotes before calling catalina scripts. This is because the catalina scripts does some Windows longpath hacking itself, and it does not expect the incoming paths to be properly quoted.

See: rev 7736, 7745, 7752 (trunk); rev 7754, 7755, 7756 (2.6)

Kalai Kannaiyan 2008-04-03

Retested with Terracotta 2.6-nightly-rev7902, as of 20080403-120417 (Revision 7902 by [email protected] from 2.6) with JAVA_HOME=C:\Program Files\Java\jdk1.6.0 and JAVA_HOME=C:\Program Files\Java\jdk1.6.0_04 on windows, it is working as expected.

Steps:

  1. Install the kit
  2. set JAVA_HOME=”C:\Program Files\Java\jdk1.6.0”
  3. Navigate to C:\Program Files\Terracotta\terracotta-trunk-nightly-rev7671\bin and execute version.bat

Actual: Terracotta 2.6-nightly-rev7902

  1. set JAVA_HOME=”C:\Program Files\Java\jdk1.6.0”
  2. Navigate to C:\Program Files\Terracotta\terracotta-trunk-nightly-rev7671\bin and execute version.bat

Actual: Terracotta 2.6-nightly-rev7902