• Bug
  • Status: Resolved
  • 1 Critical
  • Resolution: Fixed
  • amaheshw
  • Reporter: teck
  • August 23, 2010
  • 0
  • Watchers: 9
  • February 19, 2014
  • April 26, 2013

Description

When the L1 client was exclusive to the whole VM it was reasonable to make System.exit() calls on unrecoverable failures and unexpected errors. With express I don’t think we can make that argument – It is maybe reasonable to stop a particular L1 but attempting to exit the VM is stepping outside of our bounds.

This item is to clean up the code to only call System.exit() in custom mode and for express to instead just kill the originating L1. If this fix is only going into vicente then there should be no distinction for dso/custom mode.

Comments

Fiona OShea 2011-01-26

Could this break rejoin?

Tim Eck 2011-01-26

I don’t know for sure without a good deal of code reading, but the fact that there are “dead” clients out there makes me wonder whether something in them might trip a system exit.

Tim Eck 2011-01-26

I don’t know for sure without a good deal of code reading, but the fact that there are “dead” clients out there makes me wonder whether something in them might trip a system exit.

Fiona OShea 2011-12-15

Does this make sense to do in 2.5.x or do we have to wait for DSO removal?

Tim Eck 2011-12-15

I don’t think this strictly dependent on DSO removal really but it seems to fit naturally with it (timeframe wise at least).

Certainly would be part of an ehcache release (is that what you meant by 2.5.x?). This is core terracotta code, nothing really to do with ehcache

Fiona OShea 2011-12-16

I mistyped. Should have been 3.6.x. But I’ll leave it for Vicente

Tim Eck 2012-04-30

Steve asked me to assign this to you platform guys :-)

Fiona OShea 2013-01-24

‘This needs to be merged to 3.7 also. Adding that target as well.

Abhishek Maheshwari 2013-04-19

other realted jiras DEV-7477, DEV-6818, DEV-7476, CDV-1507

Abhishek Maheshwari 2013-04-24

http://fisheye.terracotta.lan/fisheye/cru/CR-897

Abhishek Maheshwari 2013-04-26

trunk - 22729 4.0.x - 22731