CDV ❯ CommitTransactionMessageImpl inconsistently synchronizes access to batchData

• Type: Bug
• Status: Closed
• Priority: 2 Major
• Resolution: Fixed
• Component/s: Communications Layer
• Labels:

• Assignee: ssubbiah
• Reporter: amiller
• Created: November 13, 2008
• Votes: 0
• Watchers: 0
• Updated:

  July 27, 2012
• Resolved:

  November 13, 2008

Description

FindBugs noticed that batchData field in this message is dehydrateValues and hydrateValue do not synchronize access to batchData while some of the other methods do. This may actually be ok in our usage patterns but someone should verify.

Comments

Saravanan Subbiah 2008-11-13

Removed unnecessary synchronization that tips off find bug. Since we move messages from one thread to another thru seda queue, that will give us the synchronization point.