History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CDV-772
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: 2 Major 2 Major
Assignee: Hung Huynh
Reporter: Fiona O'Shea
Votes: 2
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Community Development

Spring 2.0.8 and Spring 2.5.4 support

Created: 02/Jun/08 07:43 PM   Updated: 04/Aug/08 12:51 PM
Component/s: Integration Modules
Affects Version/s: None
Fix Version/s: 2.7.0-stable0

Fix In Branch: trunk
Target: 2.7
Fixed In Revision: 8936
Date of First Response: 04/Jun/08 10:39 AM


 All   Comments   Change History      Sort Order:
Fiona O'Shea - 03/Jun/08 02:46 PM
Merge 2.0.8 support to 2.6 branch

Scott Bale - 04/Jun/08 10:39 AM
Spring 2.0.8 support merged to 2.6 branch for 2.6.2 release (revision 8741)

Scott Bale - 11/Jun/08 12:06 PM

The Spring tests that have suddenly begun failing for Spring 2.0.8 are also failing for Spring 2.0.5. Hung and Jason uncovered a build problem which was resulting in the Spring container tests always running with only Spring 2.0.1 in the classpath. Now that Hung has fixed the problem, we've confirmed that these tests failed all along for Spring 2.0.5.

So I just wanted you to know that holding my 2.0.8 changes back won't fix these tests, meanwhile my changes do fix Spring events in Spring 2.0.8 and fix other test failures. So imho they should go in.

Meanwhile I'll be working on fixing these tests as well as Spring 2.5.x support.

The three tests that are failing are CustomScopedBeanTest (2 test failures) and SessionScopedBeanTest (1 failure).

Scott Bale - 13/Jun/08 05:44 PM
fixed in trunk (rev 8824) and 2.6 (8825). This fixes failing tests for Spring 2.0.5/2.0.8.

The root of the problem was that org.springframework.aop.config.ScopedProxyBeanDefinitionDecorator changed a lot from Spring 2.0.1 to 2.0.5 to 2.0.8. This is in the guts of Spring's aop interceptors, decorators and proxies, and there is a lot of room for leeway in Spring's implementation. I'm still fearful that our code (SpringAspectModule) is too tightly bound to the Spring source code - could use some refactoring imho.

Scott Bale - 25/Jun/08 01:03 PM
Rev 8936 - all tests passing now for Spring 2.5.4 variant. Not sure I'm confident saying we "support" Spring 2.5 yet...

Scott Bale - 26/Jun/08 11:16 AM
As of yesterday all automated tests are passing for all Spring variants we test, including 2.0.8 and 2.5.4.