Support for matching on subtypes for class includes

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: 2 Major 2 Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Support for matching on subtypes for class includes is supported in AW and we even had it working in spring branch at some point.

This feature would be beneficial for Spring's class hierarchy walker because it will allow to add included classes based on their supertypes (that are captured from field types by the class crawler).

Issue Links

is dependency of

New Feature - A new feature of the product, which has yet to be developed. CDV-57 Support Wicket Web Application Framework

  • 2 Major - Fix for next major release.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

New Feature - A new feature of the product, which has yet to be developed. CDV-184 RMP: Support Subtype Instrumentation

  • 1 Critical - Fix for next maintenance release (double-dot release).
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eugene Kuleshov added a comment -

Here is the old code Jonas wrote for subtype matching.

public boolean isAdaptable(ClassInfo classInfo) {
String fullName = classInfo.getName();
if (isInAdaptableCache(fullName)) { return isCachedAdaptable(fullName); }

// We make inner classes of logical classes not instrumented while logical
// bases are instrumented

String name = baseClassNameWithoutInners(fullName);
if (isLogical(name)) { return cacheIsAdaptable(fullName, name.equals(fullName)); }

if (hasCustomAdatper(fullName)) { return cacheIsAdaptable(fullName, true); }
if (getSpec(name) != null) { return cacheIsAdaptable(name, true); }
if (getSpec(fullName) != null) { return cacheIsAdaptable(name, true); }

classInfoFactory.setClassInfo(classInfo);

ExpressionContext ctxt = expressionHelper.createWithinExpressionContext(classInfo);
if (isExplicitlyExcluded(fullName, ctxt)) return cacheIsAdaptable(fullName, false);

if (isExplicitlyIncluded(ctxt)) { return cacheIsAdaptable(fullName, true); }

return cacheIsAdaptable(fullName, false);
}

Show
Eugene Kuleshov added a comment - Here is the old code Jonas wrote for subtype matching. public boolean isAdaptable(ClassInfo classInfo) { String fullName = classInfo.getName(); if (isInAdaptableCache(fullName)) { return isCachedAdaptable(fullName); } // We make inner classes of logical classes not instrumented while logical // bases are instrumented String name = baseClassNameWithoutInners(fullName); if (isLogical(name)) { return cacheIsAdaptable(fullName, name.equals(fullName)); } if (hasCustomAdatper(fullName)) { return cacheIsAdaptable(fullName, true); } if (getSpec(name) != null) { return cacheIsAdaptable(name, true); } if (getSpec(fullName) != null) { return cacheIsAdaptable(name, true); } classInfoFactory.setClassInfo(classInfo); ExpressionContext ctxt = expressionHelper.createWithinExpressionContext(classInfo); if (isExplicitlyExcluded(fullName, ctxt)) return cacheIsAdaptable(fullName, false); if (isExplicitlyIncluded(ctxt)) { return cacheIsAdaptable(fullName, true); } return cacheIsAdaptable(fullName, false); }
Hide
Permalink
Gary Keim added a comment -

Passing the buck.

Show
Gary Keim added a comment - Passing the buck.
Hide
Permalink
Fiona O'Shea added a comment -

This will not be completed in Lawton.

Show
Fiona O'Shea added a comment - This will not be completed in Lawton.
Hide
Permalink
Taylor Gautier added a comment -

does this mean selecting by interfaces will work also?

Show
Taylor Gautier added a comment - does this mean selecting by interfaces will work also?
Hide
Permalink
Eugene Kuleshov added a comment -

Implemented in trunk and tested with examples from the Wicket framework.

Show
Eugene Kuleshov added a comment - Implemented in trunk and tested with examples from the Wicket framework.
Hide
Permalink
Hung Huynh added a comment -

Hi Eugene,

I've added 2 tests that demonstrate these 2 cases:

  • Allow a user to specify an interface - all implementing classes will be instrumented
  • Allow a user to specify a parent class - all subclasses (including parent class) will be instrumented

And both of the tests fail if I just instrument the interface or the base class.

The tests name are:
InterfaceInstrumentTest
SubtypeInstrumentTest

They are currently disabled.

Show
Hung Huynh added a comment - Hi Eugene, I've added 2 tests that demonstrate these 2 cases: Allow a user to specify an interface - all implementing classes will be instrumented Allow a user to specify a parent class - all subclasses (including parent class) will be instrumented And both of the tests fail if I just instrument the interface or the base class. The tests name are: InterfaceInstrumentTest SubtypeInstrumentTest They are currently disabled.
Hide
Permalink
Eugene Kuleshov added a comment -

Hung, your test cases are NOT using expression for subtype matching. Please check the existing SubtypeMatchingTest that I've added and incorporate your tests into that one. Anyways, I've committed fix for your test apps.

Show
Eugene Kuleshov added a comment - Hung, your test cases are NOT using expression for subtype matching. Please check the existing SubtypeMatchingTest that I've added and incorporate your tests into that one. Anyways, I've committed fix for your test apps.

People

  • Assignee:
    Hung Huynh
    Reporter:
    Eugene Kuleshov
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: